pending_module_spec has misleading pending include
Reported by Joseph Wilk | December 3rd, 2008 @ 05:07 PM | in Maintenance
I was doing some digging in rspecs source to see if I could learn anything on how to create pending in Cucumber.
I notice that some of the specs in pending_module_spec were misleading. For example:
it 'should raise an ExamplePendingError if no block is supplied' do
lambda {
include Pending
pending "TODO"
}.should raise_error(ExamplePendingError, /TODO/)
end
Within the context of lamda 'include' resolves to the Spec::Matchers::Include ( [1,2,3].should include(3) ) and not the module include.
The pending method is already defined through Rspec's ExampleGroups.
I've included a patch which just removes the offending includes.
Comments and changes to this ticket
-
David Chelimsky December 3rd, 2008 @ 05:57 PM
- → State changed from “new” to “resolved”
(from [2886d9eb1a343a5f5ceb1aba7787b6daa42fc7eb]) Fixing misleading example groups where include was not resolving to module include as expected. The include was not needed so it was removed. [#621 state:resolved] http://github.com/dchelimsky/rsp...
-
David Chelimsky December 3rd, 2008 @ 05:57 PM
- → Milestone changed from “No-Milestone-Assigned” to “Maintenance”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Behaviour Driven Development for Ruby.
